Add katello repos to foremanctl installation doc#4754
Add katello repos to foremanctl installation doc#4754arvind4501 wants to merge 1 commit intotheforeman:masterfrom
Conversation
github-actions
bot
added
Needs tech review
|
The PR preview for f62a871 is available at theforeman-foreman-documentation-preview-pr-4754.surge.sh The following output files are affected by this PR: |
Gauravtalreja1
left a comment
Gauravtalreja1
left a comment
There was a problem hiding this comment.
LGTM, just a small change would be nice, could you be specific in your commit message/PR title about which guide needs update?
arvind4501
changed the title
When running `foremanctl deploy --add-feature hammer`, the installation fails because it tries to install hammer_cli_katello package but cannot find it since the Katello repository is not enabled. Installing katello-repos-latest.rpm first ensures the Katello repositories are configured before attempting to install Katello-specific packages. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jafiala
added
tech review done
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I don't want to have too detailed of an opinion, but this file contains a lot of conditionals so I'm going to share my opinions of the whole file. They don't have to be blockers for this PR, but consider it for the long term.
| ---- | ||
| endif::[] | ||
|
|
||
| ifndef::foremanctl[] |
There was a problem hiding this comment.
Since you're enabling repositories, isn't this verification also fine for foremanctl?
| + | ||
| [options="nowrap" subs="+quotes,attributes"] | ||
| ---- | ||
| # dnf copr enable @theforeman/foremanctl rhel-9-x86_64 |
There was a problem hiding this comment.
Since theforeman/foreman-packaging#12560 we package foremanctl in our repositories. For nightly this copr enablement is still OK for stable releases it should not be needed. I think we have some issue to properly track that in the release process, but I can't find that right now.
@evgeni do you happen to remember?
| ---- | ||
| # {package-install} https://yum.theforeman.org/releases/{ProjectVersion}/el{distribution-major-version}/x86_64/foreman-release.rpm | ||
| ---- | ||
| ifdef::katello[] |
There was a problem hiding this comment.
The procedure is now the same as what we have in ifdef::foreman-el,katello[] on line 40. Perhaps it should be split off into snip_configuring-repositories-foreman-rpm.adoc with (in pseudo-code):
yum install foreman-release.rpm
ifdef::katello[]
yum install katello-repos-latest.rpm
endif::[]
ifdef::foremanctl[]
dnf copr enable @theforeman/foremanctl rhel-9-x86_64
endif::[]
ifndef::foremanctl[]
yum install puppet-release.rpm
endif::[]Then in this file you'd have:
ifdef::satellite[]
...
endif::[]
ifdef::foreman-deb[]
include::snip_configuring-repositories-foreman-deb.adoc[]
endif::[]
ifdef::foreman-el,katello,foremanctl[]
include::snip_configuring-repositories-foreman-rpm.adoc[]
endif::[]Isn't that a lot easier to maintain?
5 participants
What changes are you introducing?
Add katello-repos package installation step
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
When running
foremanctl deploy --add-feature hammer, the installation fails because it tries to install hammer_cli_katello package but cannot find it since the Katello repository is not enabled. Installingkatello-repos-latest.rpm first ensures the Katello repositories are configured before attempting to install Katello-specific packages.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: